Mainline U-Boot with SPI, NVMe and SATA boot support

[belfastraven]

...
=> run bootcmd_nvme0

Device 0: Vendor: 0x144d Rev: EXD7101Q Prod: S444NE0K603440      
           Type: Hard Disk
           Capacity: 244198.3 MB = 238.4 GB (500118192 x 512)
... is now current device
** Unrecognized filesystem type **

JI'm just including the log this time so that you can see that I did use the proper images....

Once again, thanks.

@belfastraven thanks for testing, and pasting the full log here. Looks like your NVMe device is detected OK, I suspect the "Unrecognized filesystem type" problem is just because there is no BTRFS support in this build (it's not enabled in U-Boot by default).

I enabled BTRFS in the config and re-built U-Boot, I haven't tested this yet but you could try using the resulting build, attached: 
Edit: if you need the SPI binaries from this build, they can be downloaded from this build artifacts page.

I now have armbian booting from SPI flash u-boot,  its great to be booting from SPI running 5.4.8 kernel with current u-boot.  I have booted sdcard, emmc and pcie NVME.  I haven't tried with USB ports yet.  I had gone back to ext4. 

Have you thought of including an image like your flash image, that would just 0-out the flash in case of problems.  I believe ayufan has one https://github.com/ayufan-rock64/linux-u-boot/releases/download/2017.09-rockchip-ayufan-1065-g95f6152134/u-boot-erase-spi-rockpro64.img.xz  

thanks again.

@Bullet64,@sigmaris

@Bullet64,@sigmaris,Running the same self-built armbian image (5.4.8 kernel, ubuntu bionic) booting from SPI flash,
  I can boot sd, emmc, nvme,
USB3 sandisk extreme stick on esb2 ports,  but not on usb3 ports,
Samsung t1 portable SSD USb3 on USB3 ports,
and an old usb2 datatraveler stick on the usb3 ports.

  I don't understand why the usb3 stick won't boot from the USB3 port,  and have a feeling it might be a timing issue,  since the system will boot from slower devices on that port...I'm not good at hardware debugging,  but perhaps one of you will have an idea?   The way the "not booting" manifests itself is that I will get the "Starting kernel" message,  and then nothing...   which makes it hard to debug.
Sorry I had forgotten to turn the kernel log level up-- with log level at 7, I can now see that the one USB3 stick that wouldn't boot on the USB 3 port was not being recognized as a USB3 device.

usb 7-1: new full-speed USB device number 2 using xhci-hcd
[ 4.040775] usb 7-1: device descriptor read/64, error -71
[ 4.276738] usb 7-1: device descriptor read/64, error -71
[ 4.512670] usb 7-1: new full-speed USB device number 3 using xhci-hcd
[ 4.640722] usb 7-1: device descriptor read/64, error -71
[ 4.876677] usb 7-1: device descriptor read/64, error -71
[ 4.984926] usb usb7-port1: attempt power cycle
[ 5.636665] usb 7-1: new full-speed USB device number 4 using xhci-hcd
[ 5.637366] usb 7-1: Device not responding to setup address.
[ 5.844773] usb 7-1: Device not responding to setup address.
[ 6.052665] usb 7-1: device not accepting address 4, error -71
[ 6.180668] usb 7-1: new full-speed USB device number 5 using xhci-hcd
[ 6.181370] usb 7-1: Device not responding to setup address.
[ 6.388747] usb 7-1: Device not responding to setup address.
[ 6.596665] usb 7-1: device not accepting address 5, error -71
[ 6.597479] usb usb7-port1: unable to enumerate USB device
[ 10.364793] phy phy-ff770000.syscon:usb2-phy@e450.2: charger = USB_DCP_CHARGER

whereas a different USB3 stick was properly recognize and booted:

3.602830] hub 8-0:1.0: 1 port detected
[ 4.692711] usb 8-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd
[ 4.713725] usb 8-1: New USB device found, idVendor=0781, idProduct=558a, bcdDevice= 1.00
[ 4.714490] usb 8-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 4.715152] usb 8-1: Product: Ultra
[ 4.715488] usb 8-1: Manufacturer: SanDisk
[ 4.715879] usb 8-1: SerialNumber: 4C530001241105113443
[ 4.718156] usb-storage 8-1:1.0: USB Mass Storage device detected
[ 4.719355] scsi host0: usb-storage 8-1:1.0
[ 4.725283] usbcore: registered new interface driver uas
[ 5.729461] scsi 0:0:0:0: Direct-Access SanDisk Ultra 1.00 PQ: 0 ANSI: 6
[ 5.731615] sd 0:0:0:0: [sda] 240254976 512-byte logical blocks: (123 GB/115 GiB)
[ 5.733312] sd 0:0:0:0: [sda] Write Protect is off
[ 5.734191] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[ 5.775435] sda: sda1
[ 5.778568] sd 0:0:0:0: [sda] Attached SCSI removable disk
[ 5.974332] EXT4-fs (sda1): mounted filesystem with ordered data mode. Opts: (null)


Probably there was something wrong with the stick tisellf.....

So all seems good here.