mobian, pinephone camera, and megapixels

[dukla2000]

...

I thought I described my fix in my last posts in this thread (after mucking my way through the debug effort).

You did, and I applied your fix a couple weeks ago. Thanks for that!

- Norm

+1 thanks to @calinb 

As identified the "silver bullet" in megapixels is the post-processing script.

• The basic camera output is a raw .dng format
  
• It is converted to .TIFF if dcraw is installed
  
• The .TIFF is converted to .jpg if imagemagick is installed
  
• The .jpg file gets some exif data if libimage-exiftool-perl is installed (in Mobian - Arch has a different name for it)
  

I don't have a note on what any default Mobian config has but for sure I always ensure I have dcraw, imagemagick and libimage-exiftool-perl packages installed each time I rebuild my Mobian system.

The other nugget for postprocess.sh is if you put a version in ~/.config/megapixels/ then that is used in preference to the default in /usr/share/megapixels/ . Which will survive any upgrades and can do stuff the way you prefer. So my version has 3 mods:

1. the @calinb / v0.16 patch
   
2. I have commented out the initial copy of the .dng file to /Pictures as I dont want to preserve any raw images
   
3. I have added an exiftool line (and suggested it to Martijn) to set the DateTimeOriginal tag. (Because the package I use for my media library, fotoxx, can sort on that tag!)
   

My version

Code:

$ cat .config/megapixels/postprocess.sh #!/bin/sh # The post-processing script gets called after taking a burst of # pictures into a temporary directory. The first argument is the # directory containing the raw files in the burst. The contents # are 1.dng, 2.dng.... up to the number of photos in the burst. # # The second argument is the filename for the final photo without # the extension, like "/home/user/Pictures/IMG202104031234" # # The post-processing script is responsible for cleaning up # temporary directory for the burst. if [ "$#" -ne 2 ]; then echo "Usage: $0 [burst-dir] [target-name]" exit 2 fi BURST_DIR="$1" TARGET_NAME="$2" MAIN_PICTURE="$BURST_DIR"/1 # Copy the first frame of the burst as the raw photo # cp "$BURST_DIR"/1.dng "$TARGET_NAME.dng" # Create a .jpg if raw processing tools are installed DCRAW="" TIFF_EXT="dng.tiff" if command -v "dcraw_emu" > /dev/null then DCRAW=dcraw_emu # -fbdd 1 Raw denoising with FBDD set -- -fbdd 1 elif [ -x "/usr/lib/libraw/dcraw_emu" ]; then DCRAW=/usr/lib/libraw/dcraw_emu # -fbdd 1 Raw denoising with FBDD set -- -fbdd 1 elif command -v "dcraw" > /dev/null then DCRAW=dcraw TIFF_EXT="tiff" set -- fi CONVERT="" if command -v "convert" > /dev/null then CONVERT="convert" # -fbdd 1 Raw denoising with FBDD set -- -fbdd 1 elif command -v "gm" > /dev/null then CONVERT="gm" fi if [ -n "$DCRAW" ]; then # +M use embedded color matrix # -H 4 Recover highlights by rebuilding them # -o 1 Output in sRGB colorspace # -q 3 Debayer with AHD algorithm # -T Output TIFF $DCRAW +M -H 4 -o 1 -q 3 -T "$@" "$MAIN_PICTURE.dng" # If imagemagick is available, convert the tiff to jpeg and apply slight sharpening if [ -n "$CONVERT" ]; then if [ "$CONVERT" = "convert" ]; then convert "$MAIN_PICTURE.$TIFF_EXT" -sharpen 0x1.0 "$TARGET_NAME.jpg" else gm convert "$MAIN_PICTURE.$TIFF_EXT" -sharpen 0x1.0 "$TARGET_NAME.jpg" fi # If exiftool is installed copy the exif data over from the tiff to the jpeg # since imagemagick is stupid if command -v exiftool > /dev/null then exiftool -tagsFromfile "$MAIN_PICTURE.$TIFF_EXT" \ -software="Megapixels" \ -overwrite_original "$TARGET_NAME.jpg" exiftool -tagsFromFile @ "-ModifyDate>DateTimeOriginal" -overwrite_original "$TARGET_NAME.jpg" fi echo "$TARGET_NAME.jpg" else cp "$MAIN_PICTURE.$TIFF_EXT" "$TARGET_NAME.tiff" echo "$TARGET_NAME.tiff" fi fi # Clean up the temp dir containing the burst rm -rf "$BURST_DIR"