Patch to add ability to discard calls...breaks calls
02-03-2021, 08:08 PM
This one.
This was merged upstream I guess (not up on the terminology here, so bear with me). I decided to set up the sxmo build environment so I can tweak some things, so I ran the build script which installs all the latest versions of the little scripts and all that.
Today I get a call, and it starts executing my ring hook, except it's doing it over and over and over, overlapping. I go to pick up the call and it's still ringing (x100 overlapping) and also somehow hangs up when I pick it up, while still ringing. All hell is breaking loose.
So I'm testing out what broke tonight, and I disabled my ring and pickup hooks just to be sure. Sure enough, I get a call in, go to pick up, and it just hangs up immediately. There was no option to discard, so I'm guessing that the pickup and discard functions are happening simultaneously when selecting to pick up.
For now I've commented out these lines in sxmo_modemmonitor.sh in the checkforincomingcalls section:
And now it's working. Probably not the cleanest solution, but at least it's some temporary sanity until someone finds a fix.
I know this should be on the sourcehut git thing, but I'm not up to speed with all that so I figured this is the next best place.
This was merged upstream I guess (not up on the terminology here, so bear with me). I decided to set up the sxmo build environment so I can tweak some things, so I ran the build script which installs all the latest versions of the little scripts and all that.
Today I get a call, and it starts executing my ring hook, except it's doing it over and over and over, overlapping. I go to pick up the call and it's still ringing (x100 overlapping) and also somehow hangs up when I pick it up, while still ringing. All hell is breaking loose.
So I'm testing out what broke tonight, and I disabled my ring and pickup hooks just to be sure. Sure enough, I get a call in, go to pick up, and it just hangs up immediately. There was no option to discard, so I'm guessing that the pickup and discard functions are happening simultaneously when selecting to pick up.
For now I've commented out these lines in sxmo_modemmonitor.sh in the checkforincomingcalls section:
Code:
+ sxmo_notificationwrite.sh \
+ "$NOTIFDIR/incomingcall_${VOICECALLID}_notification_discard" \
+ "sxmo_modemcall.sh hangup $VOICECALLID" \
+ none \
+ "Discard - $CONTACTNAME" &And now it's working. Probably not the cleanest solution, but at least it's some temporary sanity until someone finds a fix.
I know this should be on the sourcehut git thing, but I'm not up to speed with all that so I figured this is the next best place.