(01-12-2021, 08:57 AM)marcih Wrote:Of course I'll upstream bug fixes and localization strings, but features would probably remain in my fork.(01-12-2021, 07:54 AM)ryo Wrote: Seems like it's going to be here to stay:Sounds great! Are you going to try to get your fixes and improvements upstreamed or is the fork going to be for your own personal use only?
https://source.puri.sm/Librem5/phosh/-/issues/261
So I made my own fork of Phosh, and re-enabled it by myself.
It's just 2 small file edits, so not a big deal.
But I'll probably make some more changes before I go all public with this.
Edit:
Nevermind, I'll show the code already.
https://source.puri.sm/ryo/phosh
However, I have much more planned, from fixing bugs the Purism team will probably never notice, to adding Japanese localization strings (because it seems to be super outdated by now), to adding new features even.
The Phosh source code is surprisingly easy to understand if you ever programmed in GTK+ before.
And if I don't and the Purism team notices bug fixes, they'll probably copy it into the upstream anyway.
And if they're interested in the new features, of course they're free to copy it over.
But since it looks like Purism wants to go more with the smartphone crowd while I want to make it more desktop-like, I don't think you can expect much to be cross copied over.
母語は日本語ですが、英語も喋れます(ry